892257 - [marionette-js-client] Implement new action chain marionette apis

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[James Lal [:lightsofapollo]]

Should directly mirror the python api https://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/marionette.py#104.

Comment 1

[James Lal [:lightsofapollo]]

Hey Evan,

Here is more docs for the existing marionette js client functionality:

https://github.com/mozilla-b2g/marionette_js_client

Take a look let me know what you think.

Comment 2

[Dylan Oliver [:doliver]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/53204465

Comment 3

[Dylan Oliver [:doliver]]

Dylan Oliver deleted the linked story in Pivotal Tracker

Comment 4

[James Lal [:lightsofapollo]]

marionette python examples:

http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/tests/unit/test_multi_finger.py

Comment 5

[James Lal [:lightsofapollo]]

To be clear we want to implement the functionality from Actions and MultiActions.

Quick code example:

var action = new Marionette.Action();
action.press(element).move(element).wait(3).release();

We should define the entire API first but it should be fairly clear as long as we follow the python examples.

Comment 6

[Evan Tseng [:evanxd]]

Attachment: multi-actions-errors.log

Comment 7

[Evan Tseng [:evanxd]]

Hi James,

It is the WIP patch https://github.com/evanxd/marionette_js_client/commit/8bfba0b51f3539480c6436134dc16776ce88b50c. The implementation, testing, and documentation of Actions is done.

But I have problems with MultiActions implementations.
The MultiActions cannot work in B2G desktop build client.
It always showed the below errors:
https://bug892257.bugzilla.mozilla.org/attachment.cgi?id=779203

And we could use the below example for seeing the errors:
https://github.com/evanxd/marionette_js_client/blob/8bfba0b51f3539480c6436134dc16776ce88b50c/playground/multi-actions.js.

And I am working on this issue. If you know the clues for fixing it, please help me.
Thanks. :)

Comment 8

[James Lal [:lightsofapollo]]

Evan this looks awesome! I will try to figure out what the error is...

The only other thing I would like to see is an "integration" test (see test/integration) that actually starts a b2g-desktop instance and runs a set of actions.

Comment 9

[James Lal [:lightsofapollo]]

Interesting looks like marionette throws an error for me?

  error: 
   { message: 'doc.createTouch is not a function',
     stacktrace: 'createATouch@chrome://marionette/content/marionette-listener.js:781\nsetDispatch@chrome://marionette/content/marionette-listener.js:966\nmultiAction@chrome://marionette/content/marionette-listener.js:1052\n' } }

Comment 10

[Jonathan Griffin (:jgriffin)]

See bug 890079, sounds like a similar issue.

Comment 11

[Evan Tseng [:evanxd]]

Hi all,

The issue in Comment 8 is due to Marionette server side in B2G desktop client.
The MultiActions APIs could run correctly with using real device.

And the Marionette Python Client also has the issue when we use B2G desktop client.
We already filed a bug for that in https://github.com/mozilla/gaia-ui-tests/issues/1137.

Comment 12

[Evan Tseng [:evanxd]]

Attachment: The pull request

Hi James,

I already the integration test for the Actions module.

Please help me review the patch.

Thanks. :)

Comment 13

[James Lal [:lightsofapollo]]

Comment on attachment 780410 [details]
The pull request

r=me looks fantastic!

We might want some more docs on how to use these things in the future but that will probably define itself as we use the api to write real tests.

Comment 14

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/marionette_js_client/commit/4c192ffd1e013209327ae11f7126f6cea0894f8e

Comment 15

[Evan Tseng [:evanxd]]

Hi James,

OK, I got it.

Thanks. :)

Comment 16

[Dylan Oliver [:doliver]]

Dylan Oliver changed story state to accepted in Pivotal Tracker